[Messenger] ReceiverInterface updated #11861
Merged
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jul 3, 2019
OskarStark
approved these changes
Jul 3, 2019
javiereguiluz
changed the title
javiereguiluz
added a commit
that referenced
this pull request
Jul 4, 2019
This PR was squashed before being merged into the 4.3 branch (closes #11861). Discussion ---------- [Messenger] ReceiverInterface updated Hy everyone 👋 , Due to 4.3 changements on `ReceiverInterface`, it seems that most of the existing code that we use is broken. It could be good to update the documentation according to the changements. This PR is linked to #11789. Thanks for the feedback and have a great day 🙂 Commits ------- 2c2a518 [Messenger] ReceiverInterface updated
|
Thanks Guillaume! We kindly thank you any help you can give us in Messenger-related issues and PRs. |
xabbuh
reviewed
Jul 4, 2019
|
|
||
| $handler(new Envelope($order)); | ||
| $handler($envelope); |
There was a problem hiding this comment.
Is this right? I don't see how $handler can be defined here.
javiereguiluz
added a commit
that referenced
this pull request
Sep 26, 2019
This PR was squashed before being merged into the 4.3 branch (closes #11889). Discussion ---------- [Messenger] `get()` usage Hi everyone 👋 As noticed here #11861 (comment) by @xabbuh, a small error has been found in the `get()` documentation. This PR contains a small improvement. Commits ------- 5ccad7f [Messenger] `get()` usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hy everyone 👋 ,
Due to 4.3 changements on
ReceiverInterface, it seems that most of the existing code that we use is broken.It could be good to update the documentation according to the changements.
This PR is linked to #11789.
Thanks for the feedback and have a great day 🙂